CVS log for interchange/lib/Vend/DbSearch.pm

Up to [Local Repository] / interchange / lib / Vend

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

* Fix database typing problem for HIDE_FIELD. Reported by Sonny Cook and
  found by Jon Jensen.

* Updated copyright headers to 2007 (closes bug #102)

* Added GPL and copyright headers to a few files that were missing them.

Convert nonstandard SQL != to <> especially so it works with Vend::SQL_Parser.

Thanks to Gert van der Spoel <gert@3edge.com> for pointing out the problem.

New Free Software Foundation Address in headers of various files

New Free Software Foundation Address in headers of various files

terminate search if mv_min_string condition isn't met

Big copyright and version number update to prepare for 5.3.2 release.

Remove some duplicate glob assignments for subroutines in other modules.
To do this easily, I did "expand -t4" and "LC_ALL=C sort -u".

* We had been running without warnings so long, we had gotten a bit sloppy
  in our code in some places.

  Because we do lots of uninitialized hash member stuff with arrays
  of fields and $opt, it is basically unreasonable for us to run with
  the "use of uninitialized variable" warnings. Because we do a fair
  amount of numerical comparisons on empty string values, it seemed
  unreasonable to run with "string value in numeric gt" enabled.

  Also, because Safe, HTML::Entities, and some other modules have
  these checks enabled, page code is bound to have warnings issued
  no matter what you do.

  It seems better to run with some warnings enabled so that we can
  catch bad code practice.

  So I have made the code run without warnings prior to and after
  interpolate_html(), and turned off warnings by default in the
  page code.

  If it is desirable to turn on warnings for pages, you can use
  [pragma perl_warnings_in_page] and see warnings for that page
  (or by default if you put in catalog.cfg).

* In general these changes are:

	 no warnings qw(uninitialized numeric);

  in most pages.

* Add $::Pragma->{perl_warnings_in_page}.

* Remove defined checks when simple set tests will do.

* Streamline some code.

* Fix several deficiencies in SQL parsing.

  -- Recognize IS [NOT] NULL and map to a search for the
     empty string.

  -- Allow verbatim passing of field names for GDBM types, allowing
     "select Variable from variable where Variable = ''" which
	 would not work before.

  -- Add VERBATIM_FIELDS definition to database types which need it.

  -- Add support for "select sometable as foo, othertable bar where ..."
     so that queries using it can be rerouted properly.

  -- Always set mv_min_string = 0, so we don't have to do anything
     special for "where column = ''" and such.

The great copyright, email address, URL, and version update.

updated LINUXIA branch to 4.9 sources in order to use it as testbed again

Sweeping update of Akopia/Red Hat references, to prepare for 4.8 release
with current Interchange URLs and contact information.

* Change URL generation to streamline and bring one generation routine
  for form_link, tag_page, tag_area.

  -- form_link() stuff now done in tag_area and Vend::Util::vendURL,
     aliased to tag_area

  -- tag_page() calls tag_area to get URL

  -- [order ..] also calls tag_area

  -- Add three options to page/area/order:

         no_session      eliminates mv_session_id and mv_pc always
         link_relative   links relative to current page
         match_security  generates http:// on http:// page and
                         https:// on https:// page

   -- Allow override of Scratch url format options

         option                Scratch
         ---------------       -----------------
         no_session_id         mv_no_session_id
         no_count              mv_no_count
         add_dot_html          mv_add_dot_html
         add_source            mv_add_source

* Make static page generation work again

   -- Change call to Vend::SearchObject to proper $::Instance->{SearchObject}
   -- check arguments for flypage (will probably need to remove flylist)
   -- unhexify() the scan path

* Change auto_wizard tag to use new [table-editor] tag, remove abortive
  [table-editor-tpl].

* Passes all regression tests, fully builds standard Foundation static

* Fix bug where HIDE_FIELD and screening query would not work
  together.

* Get rid of mv_range_look check now that it will be deprecated and removed
  from docs.

* Add new HIDE_FIELD capability to DbSearch. It provides automatic
  hiding of records accessed via search (and NOT query).

 -When the following configuration is added:

  	Database products HIDE_FIELD inactive

 -It adds automatically the qualification to every search:

  	WHERE inactive != 1

 -To use, you should have a field of char(1) or int type.

	Database products COLUMN_DEF "inactive=int default 0"

 -This has the side-effect of hiding fields with NULL in the
  field, so be careful. You should probably set "default 0"
  as shown above.

 -Works for DBM types too.

 -Does NOT work for TextSearch.

 -If you want to show all records, you can pass mv_no_hide=1
  in the search parameters. Obviously, this makes this not a
  security feature.

Add option to disable matchlimit entirely, with ml=all or ml=none.
Allow default of 50 to be changed in catalog variable MV_DEFAULT_MATCHLIMIT.

Oops! Should not have removed that first $s->{matches} assignment, could
have led to some breakage.

Implementing mv_max_matches as done in stable branch earlier today.

Implementing mv_max_matches: if > 0, the search results will spliced at
its offset.

Big copyright date update. This will be the last time that Red Hat
copyright notices get updated en masse, since the bulk of new code will
very likely come from non-Red Hat employees.

    * Add new mv_next_search, which allows filtering searches
      through another search after the first one returns
      some rows.

    * Add search_reference() method to Search.pm

    * Add st=ref to allow searching of an array of arrays with
      an IC search -- I would not think it too useful but this
      type of thing has been requested

    * New Vend::RefSearch actually does the search

    * Search is passed by setting in a scratch variable right now,
      suggestions on how to better pass it are appreciated

    * A small test will be posted to core list.

	* Prevent warnings on autovivify

Update version number and copyright year, to prepare for the eventual
day when we release version 4.8.4.

Attempt to make some kind of sense out of the 'valid database reference' error.

* Add new MIRROR parameter for databases. This allows creation of a
  DBM or Memory mirror.

  Sequence is:

	1. Table is always imported at config time.
	2. Table is only imported once.
	3. Text file is not required, but should be set so export
	   can work properly and so there is a placeholder.

  A complete configuration is:

	  Database  products_mem  products_mem.txt  TAB
	  Database  products_mem  MIRROR  products
	  Database  products_mem  MEMORY  1

  MIRROR name is not set in stone yet, probably not apropos
  enough; suggestions are welcome.

  Benchmarks for 1000 separate (i.e. tag_data, no caching)
  accesses (repeated tries show these are representative):

	Doing products_mem:
	Class=MEMORY DSN=
	Data returned 247 bytes
	TIME=0.200

	Doing products:
	Class=DBI DSN=dbi:mysql:test_mfound
	Data returned 247 bytes
	TIME=0.670

	Doing alias_mem:
	Class=MEMORY DSN=
	Data returned 9 bytes
	TIME=0.180

	Doing alias:
	Class=DBI DSN=dbi:Pg:dbname=wikicms
	Data returned 9 bytes
	TIME=0.700

	Doing wiki_mem:
	Class=GDBM DSN=
	Data returned 400 bytes
	TIME=0.300

	Doing wiki_mem2:
	Class=MEMORY DSN=
	Data returned 400 bytes
	TIME=0.180

	Doing wiki:
	Class=DBI DSN=dbi:Pg:dbname=wikicms
	Data returned 400 bytes
	TIME=0.710

 Gains should be even bigger as no database connections are needed
 on a busy system.

	* Make the DbSearch module search references and not tab-joined lines.

	* Search.pm now modifies its behavior for $limit_sub->() and $return_sub->()
	  to create a reference if needed.

	* This solves the tab-delimited wrong-search-result problem while
	  increasing performance up to 20% on large database records.

	* Slight change to each_nokey() routine -- it returns a
	  reference instead of a list. This should have no side-effect
	  unless someone happened to use the
	  Vend::Table::*::each_nokey() routine somewhere in custom code.
	  Certainly this is not documented as part of the API, and we
	  never use it in any of our stuff.

	* Change passes regression tests 100%. Glimpse is not really
	  tested though I anticipate no problems.

Remove tab-bug fix at Mike and Stefan's request.
To be revisited before 4.8.4 ...

Fix bug that caused search results corruption if any fields (not just
fields returned) in a given row contained a tab character. Affected e.g.
[search-region] and thus the admin/item.html page.

Comment out debug statements.

Fix bug that caused search results corruption if any fields (not just
fields returned) in a given row contained a tab character. Affected e.g.
[search-region] and thus the admin/item.html page.

Revert unnecessary change.

Remove orphaned bit of code (merge from 4.9).

Remove orphaned bit of code.

	* Put mv_base_directory back.

	* Putting mv_base_directory back

Have mv_base_directory default to ProductDir setting, not first
ProductFiles setting.

Have mv_base_directory default to ProductDir setting, not first
ProductFiles setting.

Upping major version number after trunk/branch switch.

Move DEV_4_7_0 development branch to repository trunk.

Update copyright notices and email addresses.
Standardize module headers and remove a few shebang lines.

  * Add mv_like_field and mv_like_spec to search specifications,
    designed to filter SQL (only!) searches with

		mv_like_field like 'mv_like_spec'.

	This is a stackable field/spec set like mv_search_field
	and mv_searchspec, and will eliminate any fields with empty
	mv_like_spec values.

	Checks the known_capability to see if UPPER_COMPARE is set
	for that database, and uses (pseudo-code) "UPPER($col) like "\U$spec"
	if that is the case.

  * Add known_capability UPPER_COMPARE (set for Pg and Oracle to
    begin with) to allow upper-case transforms for case-insensitive
    compares.

  * Set default table to search with MV_DEFAULT_SEARCH_TABLE.

Whitespace changes (diff -b -B will report nothing except below):

4 additional lines of diff (whitespace not caught by -b -B)

merge 1.7 vs. 1.8

also removed cuddled else statements

merged changes 1.7 vs 1.8

Fixes to make MV_DEFAULT_SEARCH_FILE work OK in DbSearch mode.

Fix bugs in or-ed searches in DbSearch, fix mv_search_relate bugs.

Fix nagging problem with "set of read-only variable" by localizing $_
in search loops.

stylistic changes

Fixed bug in hashref routine for query. This fixes a reported problem
WRT order reports not working for DBM databases.

Server:
	necessary change to support minivend->interchange script rename

DbSearch/Glimpse/TextSearch:
	comment change s/MINIVEND/INTERCHANGE on line 5

Util:
	changed -t option in syslogging routine from minivend to interchange

Changed Interchange name all over, minor exceptions being mvfaq.pod and
mvrpm.pod. Changed copyright notice to Akopia.

Added mv_start_match to find first key matching specification.
Like mv_first_match, except sets based on value of match and
not index of match.

Added more security to Session.pm, saving username safe from
manipulation by user.

Major changes to access manager. Means modifying nearly every file
to add some access permissions. This needs to be finished, but there
is a good start.

Added a customer manager.

Removed the shipping SQL/Minivend database, no longer necessary.

Vend/Config.pm
Vend/Table/Common.pm
Vend/Table/DBI.pm
	Added TableRestrict directive for restricting key access by username.
	(Mostly for transparent "view" limit of searches.) Achieves this
	by changing the each_nokey routine; could change each_record
	as well...probably shouldn't change query().
Vend/DbSearch.pm
	No real changes, removed some old debug
Vend/Order.pm
	Added card accepted limitation.

Initial import of changed Challenger with UI instead of Minimate.

Initial revision