[Interchange-bugs] [Bug 124] New - pidfile command line arg is ignored

bugzilla-daemon@localhost.akopia.com bugzilla-daemon@localhost.akopia.com
Mon, 12 Feb 2001 17:47:18 -0500


http://developer.akopia.com/bugs/show_bug.cgi?id=124

*** shadow/124	Mon Feb 12 17:47:18 2001
--- shadow/124.tmp.12638	Mon Feb 12 17:47:18 2001
***************
*** 0 ****
--- 1,47 ----
+ Bug#: 124
+ Product: Interchange
+ Version: 4.6.3
+ Platform: All
+ OS/Version: All
+ Status: NEW   
+ Resolution: 
+ Severity: minor
+ Priority: P2
+ Component: Core
+ AssignedTo: mike@minivend.com                            
+ ReportedBy: billr@exgate.tek.com               
+ URL: 
+ Cc: 
+ Summary: pidfile command line arg is ignored
+ 
+ I originally spotted this in minivend 4.04a and noticed it still exists
+ in Interchange 4.6.3.
+ 
+ A default value is set for $Global::PIDfile in interchange.pl and can
+ be overridden from the command line with the pidfile= argument.
+ Unfortunately, global_config() then resets it to 
+ $Global::VendRoot/etc/$Global::ExeName.pid.
+ 
+ In addition, the default value for SocketFile (which is not overridable
+ on the command line) is set to $Global::VendRoot/etc/socket. I think
+ a better default would be $Global::ConfDir/socket.
+ 
+ A patch for both is below. Feel free to ignore the SocketFile part of the
+ patch if you don't think it appropriate. (Whitespace edited on the patch
+ to avoid line wrapping.)
+ 
+     -Bill
+ 
+ --- Config.pm.orig	Sat Dec 30 07:17:11 2000
+ +++ Config.pm	Sun Feb 11 18:09:56 2001
+ @@ -264,8 +264,8 @@
+         ['TcpHost',          undef,             'localhost 127.0.0.1'],
+         ['SendMailProgram',  'executable', $Global::SendMailLocation								
+ || '/usr/lib/sendmail'],
+ -       ['PIDfile',     undef, "$Global::VendRoot/etc/$Global::ExeName.pid"],
+ -	['SocketFile',  undef,             "$Global::VendRoot/etc/socket"],
+ +	['PIDfile',     undef,             $Global::PIDfile],
+ +	['SocketFile',  undef,             "$Global::ConfDir/socket"],
+  	['SocketPerms',      'integer',          0600],
+  	['HouseKeeping',     'integer',          60],
+  	['Mall',	     'yesno',           'No'],