[interchange-bugs] [rt.icdevgroup.org #290] Allow hyphens in CodeDef patch

Richard Templet via RT interchange at rt.icdevgroup.org
Fri Jul 31 16:56:43 UTC 2009


<URL: http://rt.icdevgroup.org/Ticket/Display.html?id=290 >

On Fri Jul 03 07:12:12 2009, thunder wrote:
> As _ is part of \w this would probably be sufficient:
> 
> + $tag =~ s/[^-\w]+//g
> 
> Other than that the patch looks good, but we'd like to get some more
> eyes on it
> and hopefully some more tests done to make sure it does not interfere
> with
> other parts of the codebase.


Attached are the files I used to test this patch.  I've also included below the little sub I used to ensure that the filters could work within Global perl modules as well after the patch was installed.

sub testing_stuff {

        $::Scratch->{testing} = $::Tag->filter({ op => "test_123", body => "123.456578" });
        $::CGI->{mv_nextpage} = 'index.html';
        return 1;
}

Let me know if you need anything else.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: test-123.filter
Type: application/octet-stream
Size: 690 bytes
Desc: not available
Url : http://www.icdevgroup.org/pipermail/interchange-bugs/attachments/20090731/b444248e/attachment.obj 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: test_123.filter
Type: application/octet-stream
Size: 690 bytes
Desc: not available
Url : http://www.icdevgroup.org/pipermail/interchange-bugs/attachments/20090731/b444248e/attachment-0001.obj 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: test_123.am
Type: application/octet-stream
Size: 81 bytes
Desc: not available
Url : http://www.icdevgroup.org/pipermail/interchange-bugs/attachments/20090731/b444248e/attachment-0002.obj 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.icdevgroup.org/pipermail/interchange-bugs/attachments/20090731/b444248e/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: test-123.am
Type: application/octet-stream
Size: 81 bytes
Desc: not available
Url : http://www.icdevgroup.org/pipermail/interchange-bugs/attachments/20090731/b444248e/attachment-0003.obj 


More information about the interchange-bugs mailing list