[interchange-bugs] [rt.icdevgroup.org #310] Business::OnlinePayment supplemental parameters

[Jon Jensen via RT]

Tue Sep 01 20:44:30 2009: Request 310 was acted upon.
Transaction: Ticket created by jon
       Queue: Interchange
     Subject: Business::OnlinePayment supplemental parameters
       Owner: Nobody
  Requestors: jon at endpoint.com
      Status: new
 Ticket <URL: http://rt.icdevgroup.org/Ticket/Display.html?id=310 >


Date: Wed, 26 Aug 2009 14:50:08 -0400
From: Richard Siddall <richard.siddall at elirion.net>
To: Interchange Users <interchange-users at icdevgroup.org>
Subject: [ic] Patch for Vend::Payment::BusinessOnlinePayment
Message-ID: <4A9583E0.1050800 at elirion.net>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
    rv:1.8.1.22) Gecko/20090605 SeaMonkey/1.1.17

Attached is a patch for Vend::Payment::BusinessOnlinePayment in Interchange 5.6.0.  It fixes a bug where supplemental parameters
passed to the payment module to initialize the Business::OnlinePayment gateway object get a value of 1 instead of what's in your
catalog.cfg or products/variable.txt.

Please let me know if I have to submit this via github.

Regards,

        Richard Siddall


diff -Naur interchange-5.6.0.orig/lib/Vend/Payment/BusinessOnlinePayment.pm
interchange-5.6.0/lib/Vend/Payment/BusinessOnlinePayment.pm
--- interchange-5.6.0.orig/lib/Vend/Payment/BusinessOnlinePayment.pm    2005-01-24 09:38:59.000000000 -0500
+++ interchange-5.6.0/lib/Vend/Payment/BusinessOnlinePayment.pm 2009-08-26 14:37:23.000000000 -0400
@@ -226,7 +226,7 @@
 
   #processor options!
   my %ignore = map { $_=>1 } qw(gateway processor id secret transaction );
-  my %options = map  { $_=>1 }
+  my %options = map  { $_=>($$opt{$_} || $main::Variable{"MV_PAYMENT_" . $_ }) }
                 grep { !$ignore{$_} } (
                                         keys(%$opt),
                                         map { s/^MV_PAYMENT_//; lc($_); }


    [ Part 3: "Attached Text" ]

_______________________________________________
interchange-users mailing list
interchange-users at icdevgroup.org
http://www.icdevgroup.org/mailman/listinfo/interchange-users