[interchange-cvs] CVS notice: activity by racke

Mike Heins interchange-cvs@lists.akopia.com
Tue Jun 5 14:41:00 2001


Quoting interchange-cvs@developer.akopia.com (interchange-cvs@developer.akopia.com):
> CVS activity by user 'racke':
> interchange/dist/lib/UI/pages/admin gentable.html,1.12.4.8,1.12.4.9
> Update of /anon_cvs/repository/interchange/dist/lib/UI/pages/admin
> In directory developer.akopia.com:/tmp/cvs-serv19144
> 
> Modified Files:
>       Tag: DEV_4_7_0
> 	gentable.html 
> Log Message:
> Gross hack to get it working without cookies.
> I've no idea why we aren't using $Tag->area(..) to build the URLs.
> If there is a reason, please tell me, otherwise I fix the code.

One reason is the add_dot_html, which we want to avoid on the download
link. I got around that by using the form parameter generation, which
never adds the .html extension. We should probably set mv_add_dot_html = 0
in the admin interface anyway....

The rest is a perhaps-misguided attempt at efficiency, trying to prevent
a couple of hundred calls to $Tag->area(). There is no reason not to
fix the code...and I have done so.

-- 
Red Hat, Inc., 3005 Nichols Rd., Hamilton, OH  45013
phone +1.513.523.7621      <mheins@redhat.com>

Being against torture ought to be sort of a bipartisan thing.
-- Karl Lehenbauer