[interchange-cvs] interchange - jon modified lib/Vend/Order.pm

interchange-core@interchange.redhat.com interchange-core@interchange.redhat.com
Thu Apr 25 13:58:01 2002


User:      jon
Date:      2002-04-25 17:56:23 GMT
Modified:  lib/Vend Order.pm
Log:
Tweak debug messages, and comment out.

Revision  Changes    Path
2.18      +6 -7      interchange/lib/Vend/Order.pm


rev 2.18, prev_rev 2.17
Index: Order.pm
===================================================================
RCS file: /var/cvs/interchange/lib/Vend/Order.pm,v
retrieving revision 2.17
retrieving revision 2.18
diff -u -u -r2.17 -r2.18
--- Order.pm	25 Apr 2002 17:07:58 -0000	2.17
+++ Order.pm	25 Apr 2002 17:56:23 -0000	2.18
@@ -1,6 +1,6 @@
 # Vend::Order - Interchange order routing routines
 #
-# $Id: Order.pm,v 2.17 2002/04/25 17:07:58 jon Exp $
+# $Id: Order.pm,v 2.18 2002/04/25 17:56:23 jon Exp $
 #
 # Copyright (C) 1996-2001 Red Hat, Inc. <interchange@redhat.com>
 #
@@ -28,7 +28,7 @@
 package Vend::Order;
 require Exporter;
 
-$VERSION = substr(q$Revision: 2.17 $, 10);
+$VERSION = substr(q$Revision: 2.18 $, 10);
 
 @ISA = qw(Exporter);
 
@@ -849,19 +849,18 @@
 					);
 			return undef;
 		}
-#::logDebug("&Vend::Order::do_check returning \$val $val, \$var $var, \$message $message");
+#::logDebug("&Vend::Order::do_check returning val=$val, var=$var, message=$message");
 		return ($val, $var, $message);
 }
 
 sub check_order {
 	my ($profiles, $vref) = @_;
-	my @profiles = split /\0+/, $profiles;
 	my $status;
 	@Errors = ();
 	$Vend::Session->{errors} = {}
 		unless ref $Vend::Session->{errors} eq 'HASH';
 
-	for my $profile (@profiles) {
+	for my $profile (split /\0+/, $profiles) {
 
 		$status = check_order_each($profile, $vref);
 
@@ -880,7 +879,7 @@
 						"You might want to order something! No items in cart.",
 					);
 		}
-::logDebug("FINISH checking profile $profile: Fatal=$Fatal Final=$Final Status=$status");
+#::logDebug("FINISH checking profile $profile: Fatal=$Fatal Final=$Final Status=$status");
 
 		# first profile to fail prevents all other profiles from running
 		last unless $status;
@@ -888,7 +887,7 @@
 	}
 
 	my $errors = join "\n", @Errors;
-::logDebug("Errors after checking profile(s) " . join(", ", @profiles) . ":\n" . $errors);
+#::logDebug("Errors after checking profile(s):\n$errors") if $errors;
 	$errors = '' unless defined $errors and ! $Success;
 	return ($status, $Final, $errors);
 }