[interchange-cvs] interchange - jon modified lib/Vend/Payment/Signio.pm

[interchange-core@icdevgroup.org]

User:      jon
Date:      2002-10-12 11:43:58 GMT
Modified:  lib/Vend/Payment Signio.pm
Log:
Patch from Mark Johnson, whose explanation I quote:

If you send a garbage ORIGID, as IC does by default, it will attempt to
use that as the key for the transaction, without falling back on the data
you sent with it. Thus, it must explicitly not be used unless you have a
valid one which you want to use. This was why no credits were succeeding;
even though we were sending explicit new data, it ignored it and cried
with the ever useful error "Not signed up for this tender type".

Revision  Changes    Path
2.3       +6 -4      interchange/lib/Vend/Payment/Signio.pm


rev 2.3, prev_rev 2.2
Index: Signio.pm
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /var/cvs/interchange/lib/Vend/Payment/Signio.pm,v
retrieving revision 2.2
retrieving revision 2.3
diff -u -u -r2.2 -r2.3
--- Signio.pm	27 Aug 2002 22:06:16 -0000	2.2
+++ Signio.pm	12 Oct 2002 11:43:58 -0000	2.3
@@ -1,6 +1,6 @@
 # Vend::Payment::Signio - Interchange Signio support
 #
-# $Id: Signio.pm,v 2.2 2002/08/27 22:06:16 jon Exp $
+# $Id: Signio.pm,v 2.3 2002/10/12 11:43:58 jon Exp $
 #
 # Copyright (C) 1999-2002 Red Hat, Inc. <interchange@redhat.com>
 #
@@ -27,7 +27,7 @@
=20
 =3Dhead1 Interchange Signio Support
=20
-Vend::Payment::Signio $Revision: 2.2 $
+Vend::Payment::Signio $Revision: 2.3 $
=20
 =3Dhead1 SYNOPSIS
=20
@@ -357,7 +357,7 @@
 			);
=20=09
=20
-	my $orderID =3D $opt->{order_id} || gen_order_id($opt);
+	my $orderID =3D $opt->{order_id};
 	$amount =3D $opt->{total_cost} if ! $amount;
=20
     if(! $amount) {
@@ -378,7 +378,6 @@
                     SHIPTOZIP   =3D> $actual{zip},
                     EXPDATE     =3D> $exp,
                     TENDER      =3D> 'C',
-                    ORIGID      =3D> $orderID,
                     PWD         =3D> $secret,
                     USER        =3D> $user,
 					TRXTYPE		=3D> $transtype,
@@ -386,6 +385,9 @@
=20
 	$query{PARTNER} =3D $opt->{partner} || charge_param('partner');
 	$query{VENDOR}  =3D $opt->{vendor}  || charge_param('vendor');
+	$query{ORIGID} =3D $orderID if $orderID;
+
+	$orderID ||=3D gen_order_id($opt);
=20
     for (keys %varmap) {
         $query{$_} =3D $actual{$varmap{$_}};