[interchange-cvs] interchange - jon modified lib/Vend/Payment/Signio.pm

[interchange-core@icdevgroup.org]

User:      jon
Date:      2003-06-07 00:47:52 GMT
Modified:  lib/Vend/Payment Signio.pm
Log:
Add new Verisign route parameter, "check_sub", which allows a Sub or
GlobalSub to be called after a successful charge for a check of some
sort. Documentation is in POD in the module.

There probably isn't a need for similar functionality in other payment
modules, but if the need ever arises, this is general enough that it could
be used elsewhere.

Revision  Changes    Path
2.9       +64 -3     interchange/lib/Vend/Payment/Signio.pm


rev 2.9, prev_rev 2.8
Index: Signio.pm
===================================================================
RCS file: /var/cvs/interchange/lib/Vend/Payment/Signio.pm,v
retrieving revision 2.8
retrieving revision 2.9
diff -u -u -r2.8 -r2.9
--- Signio.pm	7 Apr 2003 12:11:01 -0000	2.8
+++ Signio.pm	7 Jun 2003 00:47:52 -0000	2.9
@@ -1,8 +1,9 @@
 # Vend::Payment::Signio - Interchange support for Signio/Verisign Payflow Pro
 #
-# $Id: Signio.pm,v 2.8 2003/04/07 12:11:01 mheins Exp $
+# $Id: Signio.pm,v 2.9 2003/06/07 00:47:52 jon Exp $
 #
-# Copyright (C) 1999-2003 Red Hat, Inc. and Interchange Development Group
+# Copyright (C) 2003 Interchange Development Group
+# Copyright (C) 1999-2002 Red Hat, Inc.
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -23,7 +24,7 @@
 
 =head1 Interchange support for Signio/Verisign Payflow Pro
 
-Vend::Payment::Signio $Revision: 2.8 $
+Vend::Payment::Signio $Revision: 2.9 $
 
 =head1 SYNOPSIS
 
@@ -190,6 +191,51 @@
 
 =back
 
+=item check_sub
+
+Name of a Sub or GlobalSub to be called after the result hash has been
+received from Verisign. A reference to the modifiable result hash is
+passed into the subroutine, and it should return true (in the Perl truth
+sense) if its checks were successful, or false if not.
+
+This can come in handy since, strangely, Verisign has no option to decline
+a charge when AVS or CSC data come back negative. See Verisign knowledge
+base articles vs2365, vs7779, vs12717, and vs22810 for more details.
+
+If you want to fail based on a bad AVS check, make sure you're only
+doing an auth -- B<not a sale>, or your customers would get charged on
+orders that fail the AVS check and never get logged in your system!
+
+Add the parameters like this:
+
+	Route  signio  check_sub  avs_check
+
+This is a matching sample subroutine you could put in interchange.cfg:
+
+	GlobalSub <<EOR
+	sub avs_check {
+		my ($result) = @_;
+		my ($addr, $zip) = @{$result}{qw( AVSADDR AVSZIP )};
+		return 1 if $addr eq 'Y' or $zip eq 'Y';
+		return 1 if $addr eq 'X' and $zip eq 'X';
+		return 1 if $addr !~ /\S/ and $zip !~ /\S/;
+		$result->{RESULT} = 112;
+		$result->{RESPMSG} = "The billing address you entered does not match the cardholder's billing address";
+		return 0;
+	}
+	EOR
+
+That would work equally well as a Sub in catalog.cfg. It will succeed if
+either the address or zip is 'Y', or if both are unknown. If it fails,
+it sets the result code and error message in the result hash using
+Verisign's own (otherwise unused) 112 result code, meaning "Failed AVS
+check".
+
+Of course you can use this sub to do any other post-processing you
+want as well.
+
+=back
+
 =head2 Troubleshooting
 
 Try the instructions above, then enable test mode. A test order should complete.
@@ -533,6 +579,21 @@
     	%$result = split /[&=]/, $resultstr;
 	}
 #::logDebug(qq{signio decline=$decline result: $resultstr});
+
+	if (
+		! $decline and 
+		my $check_sub_name = $opt->{check_sub} || charge_param('check_sub')
+	) {
+		my $check_sub = $Vend::Cfg->{Sub}{$check_sub_name}
+			|| $Global::GlobalSub->{$check_sub_name};
+		if (ref $check_sub eq 'CODE') {
+			$decline = ! $check_sub->($result);
+#::logDebug(qq{signio called check_sub sub=$check_sub_name decline=$decline});
+		}
+		else {
+			logError("signio: non-existent check_sub routine %s.", $check_sub_name);
+		}
+	}
 
     my %result_map = ( qw/
             MStatus               ICSTATUS