[interchange-cvs] interchange - jon modified code/Filter/dbi_quote.filter

[interchange-cvs at icdevgroup.org]

User:      jon
Date:      2005-11-10 02:36:48 GMT
Modified:  code/Filter dbi_quote.filter
Log:
Make code more readable, as suggested by Stefan.

Revision  Changes    Path
1.2       +10 -7     interchange/code/Filter/dbi_quote.filter


rev 1.2, prev_rev 1.1
Index: dbi_quote.filter
===================================================================
RCS file: /var/cvs/interchange/code/Filter/dbi_quote.filter,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -u -r1.1 -r1.2
--- dbi_quote.filter	4 Oct 2005 19:31:27 -0000	1.1
+++ dbi_quote.filter	10 Nov 2005 02:36:48 -0000	1.2
@@ -1,18 +1,21 @@
 # Copyright 2005 Interchange Development Group (http://www.icdevgroup.org/)
 # Licensed under the GNU GPL v2. See file LICENSE for details.
-# $Id: dbi_quote.filter,v 1.1 2005/10/04 19:31:27 jon Exp $
+# $Id: dbi_quote.filter,v 1.2 2005/11/10 02:36:48 jon Exp $
 
 CodeDef dbi_quote Filter
 CodeDef dbi_quote Description SQL quoting using DBI
 CodeDef dbi_quote Routine <<EOR
 sub {
-	my $val = shift;
-	shift;  # get rid of tag
-	my $table = shift || $Vend::Cfg->{ProductFiles}[0];
-	my $db = dbref($table) or do {
-		::logError("filter dbi_quote couldn't find dbref for table '%s'", $table);
+	my ($val, $tag, $table) = @_;
+
+	$table ||= $Vend::Cfg->{ProductFiles}[0];
+
+	my $db;
+	unless ($db = dbref($table)) {
+		::logError("filter dbi_quote cannot find database handle for table '%s'", $table);
 		return;
-	};
+	}
+
 	return $db->quote($val);
 }
 EOR