[interchange-cvs] interchange - heins modified 4 files

interchange-cvs at icdevgroup.org interchange-cvs at icdevgroup.org
Wed Aug 16 09:34:10 EDT 2006


User:      heins
Date:      2006-08-16 13:34:09 GMT
Modified:  lib/Vend Search.pm Util.pm
Modified:  lib/Vend/Accounting SQL_Ledger.pm
Modified:  lib/Vend/Payment Linkpoint.pm
Log:
* Remove all cases of "split //", which if modified could conceivably
  conflict with new // operator in Perl 5.10 (though that would be unlikely).

Revision  Changes    Path
2.32      +3 -3      interchange/lib/Vend/Search.pm


rev 2.32, prev_rev 2.31
Index: Search.pm
===================================================================
RCS file: /var/cvs/interchange/lib/Vend/Search.pm,v
retrieving revision 2.31
retrieving revision 2.32
diff -u -r2.31 -r2.32
--- Search.pm	5 Jul 2006 13:19:54 -0000	2.31
+++ Search.pm	16 Aug 2006 13:34:09 -0000	2.32
@@ -1,6 +1,6 @@
 # Vend::Search - Base class for search engines
 #
-# $Id: Search.pm,v 2.31 2006/07/05 13:19:54 kwalsh Exp $
+# $Id: Search.pm,v 2.32 2006/08/16 13:34:09 mheins Exp $
 #
 # Copyright (C) 2002-2004 Interchange Development Group
 # Copyright (C) 1996-2002 Red Hat, Inc.
@@ -22,7 +22,7 @@
 
 package Vend::Search;
 
-$VERSION = substr(q$Revision: 2.31 $, 10);
+$VERSION = substr(q$Revision: 2.32 $, 10);
 
 use strict;
 no warnings qw(uninitialized numeric);
@@ -424,7 +424,7 @@
 	$last = 0;
 	for ($i = 0; $i < @$out; $i++) {
 		$sortkey = $out->[$i]->[$sfpos];
-		@letters = split(//, $sortkey, $alphachars + 1);
+		@letters = split(m{}, $sortkey, $alphachars + 1);
 		pop(@letters);
 		$changed = 0;
 



2.95      +6 -6      interchange/lib/Vend/Util.pm


rev 2.95, prev_rev 2.94
Index: Util.pm
===================================================================
RCS file: /var/cvs/interchange/lib/Vend/Util.pm,v
retrieving revision 2.94
retrieving revision 2.95
diff -u -r2.94 -r2.95
--- Util.pm	5 Apr 2006 15:31:38 -0000	2.94
+++ Util.pm	16 Aug 2006 13:34:09 -0000	2.95
@@ -1,6 +1,6 @@
 # Vend::Util - Interchange utility functions
 #
-# $Id: Util.pm,v 2.94 2006/04/05 15:31:38 mheins Exp $
+# $Id: Util.pm,v 2.95 2006/08/16 13:34:09 mheins Exp $
 # 
 # Copyright (C) 2002-2005 Interchange Development Group
 # Copyright (C) 1996-2002 Red Hat, Inc.
@@ -88,7 +88,7 @@
 use Vend::File;
 use subs qw(logError logGlobal);
 use vars qw($VERSION @EXPORT @EXPORT_OK);
-$VERSION = substr(q$Revision: 2.94 $, 10);
+$VERSION = substr(q$Revision: 2.95 $, 10);
 
 my $Eval_routine;
 my $Eval_routine_file;
@@ -162,7 +162,7 @@
     my($c, $r);
 
     $r = '';
-    foreach $c (split(//, $in)) {
+    foreach $c (split(m{}, $in)) {
 		$r .= $ESCAPE_CHARS::translate[ord($c)];
     }
 
@@ -179,7 +179,7 @@
     my($c, $r);
 
     $r = '';
-    foreach $c (split(//, $in)) {
+    foreach $c (split(m{}, $in)) {
 		$r .= $ESCAPE_CHARS::translate_url[ord($c)];
     }
 
@@ -264,7 +264,7 @@
 	$num =~ /^(\d*)(?:\.(\d+))?$/
 		or return $num;
 	my $int = $1;
-	@frac = split(//, ($2 || 0));
+	@frac = split(m{}, ($2 || 0));
 	local($^W) = 0;
 	my $frac = join "", @frac[0 .. $digits - 1];
 	if($frac[$digits] > 4) {
@@ -350,7 +350,7 @@
 	my $len = length($1);
 	$amount = sprintf('%.' . $len . 'f', $amount);
 	$amount =~ tr/0-9//cd;
-	my (@dig) = split //, $amount;
+	my (@dig) = split m{}, $amount;
 	$pic =~ s/#/pop(@dig)/eg;
 	$pic =~ s/\Q$sep\E+(?!\d)//;
 	$pic =~ s/\d/*/g if @dig;



1.13      +4 -4      interchange/lib/Vend/Accounting/SQL_Ledger.pm


rev 1.13, prev_rev 1.12
Index: SQL_Ledger.pm
===================================================================
RCS file: /var/cvs/interchange/lib/Vend/Accounting/SQL_Ledger.pm,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- SQL_Ledger.pm	8 Nov 2005 18:14:46 -0000	1.12
+++ SQL_Ledger.pm	16 Aug 2006 13:34:09 -0000	1.13
@@ -1,6 +1,6 @@
 #
 # Vend::Accounting::SQL_Ledger
-# $Id: SQL_Ledger.pm,v 1.12 2005/11/08 18:14:46 jon Exp $
+# $Id: SQL_Ledger.pm,v 1.13 2006/08/16 13:34:09 mheins Exp $
 #
 # SQL-Ledger Accounting Interface for Interchange
 #
@@ -1148,19 +1148,19 @@
     if ($myconfig->{numberformat} && ($myconfig->{numberformat} ne '1000.00')) {
       my ($whole, $dec) = split /\./, "$amount";
       $whole =~ s/-//;
-      $amount = join '', reverse split //, $whole;
+      $amount = join '', reverse split m{}, $whole;
       
       if ($myconfig->{numberformat} eq '1,000.00') {
 	$amount =~ s/\d{3,}?/$&,/g;
 	$amount =~ s/,$//;
-	$amount = join '', reverse split //, $amount;
+	$amount = join '', reverse split m{}, $amount;
 	$amount .= "\.$dec" if $dec;
       }
       
       if ($myconfig->{numberformat} eq '1.000,00') {
 	$amount =~ s/\d{3,}?/$&./g;
 	$amount =~ s/\.$//;
-	$amount = join '', reverse split //, $amount;
+	$amount = join '', reverse split m{}, $amount;
 	$amount .= ",$dec" if $dec;
       }
       



1.9       +2 -2      interchange/lib/Vend/Payment/Linkpoint.pm


rev 1.9, prev_rev 1.8
Index: Linkpoint.pm
===================================================================
RCS file: /var/cvs/interchange/lib/Vend/Payment/Linkpoint.pm,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- Linkpoint.pm	19 May 2006 14:46:52 -0000	1.8
+++ Linkpoint.pm	16 Aug 2006 13:34:09 -0000	1.9
@@ -1,6 +1,6 @@
 # Vend::Payment::Linkpoint - Interchange Linkpoint support
 #
-# $Id: Linkpoint.pm,v 1.8 2006/05/19 14:46:52 jon Exp $
+# $Id: Linkpoint.pm,v 1.9 2006/08/16 13:34:09 mheins Exp $
 #
 # Copyright (C) 2002-2006 Interchange Development Group
 # Copyright (C) 2002 Stefan Hornburg (Racke) <racke at linuxia.de>
@@ -132,7 +132,7 @@
 	sub avs_check {
 		my ($result) = @_;
 		my $avs = $result->{r_avs};
-		my ($addr, $zip) = split //, $avs;
+		my ($addr, $zip) = split m{}, $avs;
 		return 1 if $addr eq 'Y' or $zip eq 'Y';
 		return 1 if $addr eq 'X' and $zip eq 'X';
 		$result->{MStatus} = 'failure';








More information about the interchange-cvs mailing list