[interchange-cvs] interchange - racke modified 2 files

[interchange-cvs at icdevgroup.org]

User:      racke
Date:      2006-08-25 11:33:26 GMT
Modified:  .        WHATSNEW-5.5
Modified:  lib/Vend SOAP.pm
Log:
Return proper SOAP error to the client instead of disclosing our faults.

Revision  Changes    Path
1.17      +5 -0      interchange/WHATSNEW-5.5


rev 1.17, prev_rev 1.16
Index: WHATSNEW-5.5
===================================================================
RCS file: /var/cvs/interchange/WHATSNEW-5.5,v
retrieving revision 1.16
retrieving revision 1.17
diff -u -r1.16 -r1.17
--- WHATSNEW-5.5	22 Aug 2006 14:46:20 -0000	1.16
+++ WHATSNEW-5.5	25 Aug 2006 11:33:26 -0000	1.17
@@ -108,3 +108,8 @@
 * Cleaned up splash page and fixed broken links.
 
 * Add CVV2 support to checkout pages, images thanks to Jure Kodzoman.
+
+SOAP
+----
+
+* Return proper SOAP error to the client instead of disclosing our faults.



2.16      +6 -3      interchange/lib/Vend/SOAP.pm


rev 2.16, prev_rev 2.15
Index: SOAP.pm
===================================================================
RCS file: /var/cvs/interchange/lib/Vend/SOAP.pm,v
retrieving revision 2.15
retrieving revision 2.16
diff -u -r2.15 -r2.16
--- SOAP.pm	8 Nov 2005 18:14:45 -0000	2.15
+++ SOAP.pm	25 Aug 2006 11:33:26 -0000	2.16
@@ -1,6 +1,6 @@
 # Vend::SOAP - Handle SOAP connections for Interchange
 #
-# $Id: SOAP.pm,v 2.15 2005/11/08 18:14:45 jon Exp $
+# $Id: SOAP.pm,v 2.16 2006/08/25 11:33:26 racke Exp $
 #
 # Copyright (C) 2002-2005 Interchange Development Group
 # Copyright (C) 2000-2002 Red Hat, Inc.
@@ -35,7 +35,7 @@
 use strict;
 
 use vars qw($VERSION @ISA $AUTOLOAD);
-$VERSION = substr(q$Revision: 2.15 $, 10);
+$VERSION = substr(q$Revision: 2.16 $, 10);
 @ISA = qw/SOAP::Server/;
 
 my %Allowed_tags;
@@ -413,7 +413,10 @@
 	
 	my $error;
 	if($@) {
-		$error = errmsg("SOAP tag call failed: %s", $@);
+		::logError("SOAP call for $routine failed: %s", $@);
+		
+		$error = SOAP::Server->make_fault($SOAP::Constants::FAULT_SERVER,
+							   'Application error');
 	}
 #::logDebug("session " . ::full_dump() );