[interchange-cvs] interchange - kwalsh modified lib/Vend/Util.pm

[interchange-cvs at icdevgroup.org]

User:      kwalsh
Date:      2006-10-11 22:10:48 GMT
Modified:  lib/Vend Util.pm
Log:
    * If Net::SMTP failes to instantiate then the $smtp variable remains
      undefined.  This leads to bombshells such as "Can't call method "mail"
      on an undefined value".

Revision  Changes    Path
2.98      +3 -3      interchange/lib/Vend/Util.pm


rev 2.98, prev_rev 2.97
Index: Util.pm
===================================================================
RCS file: /var/cvs/interchange/lib/Vend/Util.pm,v
retrieving revision 2.97
retrieving revision 2.98
diff -u -r2.97 -r2.98
--- Util.pm	9 Oct 2006 22:09:52 -0000	2.97
+++ Util.pm	11 Oct 2006 22:10:48 -0000	2.98
@@ -1,6 +1,6 @@
 # Vend::Util - Interchange utility functions
 #
-# $Id: Util.pm,v 2.97 2006/10/09 22:09:52 kwalsh Exp $
+# $Id: Util.pm,v 2.98 2006/10/11 22:10:48 kwalsh Exp $
 # 
 # Copyright (C) 2002-2005 Interchange Development Group
 # Copyright (C) 1996-2002 Red Hat, Inc.
@@ -88,7 +88,7 @@
 use Vend::File;
 use subs qw(logError logGlobal);
 use vars qw($VERSION @EXPORT @EXPORT_OK);
-$VERSION = substr(q$Revision: 2.97 $, 10);
+$VERSION = substr(q$Revision: 2.98 $, 10);
 
 my $Eval_routine;
 my $Eval_routine_file;
@@ -1972,7 +1972,7 @@
 #::logDebug("using $using");
 		undef $none;
 
-		my $smtp = Net::SMTP->new($mhost, Debug => $Global::Variable->{DEBUG}, Hello => $helo);
+		my $smtp = Net::SMTP->new($mhost, Debug => $Global::Variable->{DEBUG}, Hello => $helo) or last SMTP;
 #::logDebug("smtp object $smtp");
 
 		my $from = $::Variable->{MV_MAILFROM}