[interchange-cvs] interchange - kwalsh modified lib/Vend/Ship.pm
interchange-cvs at icdevgroup.org
interchange-cvs at icdevgroup.org
Wed Sep 20 08:33:42 EDT 2006
User: kwalsh
Date: 2006-09-20 12:33:42 GMT
Modified: lib/Vend Tag: STABLE_5_4-branch Ship.pm
Log:
* Autovivification issue: The temporary mv_shipping cart was left
undefined instead of being removed in some cases. In fact, in the
test case that showed the error, the mv_shipping cart was just being
defined as undef and left as-is. The undef "cart" caused problems
in later cart recalculations.
(back-ported from CVS HEAD)
Revision Changes Path
No revision
No revision
2.13.2.3 +2 -2 interchange/lib/Vend/Ship.pm
rev 2.13.2.3, prev_rev 2.13.2.2
Index: Ship.pm
===================================================================
RCS file: /var/cvs/interchange/lib/Vend/Ship.pm,v
retrieving revision 2.13.2.2
retrieving revision 2.13.2.3
diff -u -r2.13.2.2 -r2.13.2.3
--- Ship.pm 3 Feb 2006 15:35:36 -0000 2.13.2.2
+++ Ship.pm 20 Sep 2006 12:33:42 -0000 2.13.2.3
@@ -1,6 +1,6 @@
# Vend::Ship - Interchange shipping code
#
-# $Id: Ship.pm,v 2.13.2.2 2006/02/03 15:35:36 mheins Exp $
+# $Id: Ship.pm,v 2.13.2.3 2006/09/20 12:33:42 kwalsh Exp $
#
# Copyright (C) 2002-2005 Interchange Development Group
# Copyright (C) 1996-2002 Red Hat, Inc.
@@ -852,7 +852,7 @@
SHIPFORMAT: {
$Vend::Session->{ship_message} .= $error_message . ($error_message =~ / $/ ? '' : ' ')
if defined $error_message;
- undef $::Carts->{mv_shipping};
+ delete $::Carts->{mv_shipping};
$Vend::Items = $save;
#::logDebug("Check FINAL. Vend::Items=$Vend::Items main=$::Carts->{main}");
last SHIPFORMAT unless defined $final;
More information about the interchange-cvs
mailing list