[interchange] Fix nesting problem in PayPal affecting b_state

Josh Lavin interchange-cvs at icdevgroup.org
Mon Nov 28 21:28:39 UTC 2016


commit a452f1c40187d6a478523dedd0a47a34bb53d3ac
Author: Josh Lavin <digory at cpan.org>
Date:   Mon Nov 28 13:27:21 2016 -0800

    Fix nesting problem in PayPal affecting b_state
    
    when pp_use_billing_address was set. Original code would have the effect
    of never allowing b_state to be updated on a second return from PayPal.
    It seems the idea for b_state & state to be updated in this spot is for
    Canadian changes.

 lib/Vend/Payment/PaypalExpress.pm |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)
---
diff --git a/lib/Vend/Payment/PaypalExpress.pm b/lib/Vend/Payment/PaypalExpress.pm
index 6a0ff48..5f641a2 100644
--- a/lib/Vend/Payment/PaypalExpress.pm
+++ b/lib/Vend/Payment/PaypalExpress.pm
@@ -1049,11 +1049,10 @@ return $Tag->deliver({ location => $redirecturl });
 		$state = 'QC' if ($state =~ /Quebec|^QC$/i);
 		$state = 'SK' if ($state =~ /Saskatchewan|^SK$/i);
 		$state = 'YT' if ($state =~ /Yukon|^YT$/i);
-	}
-        
         $::Values->{'b_state'} = $state if ($::Values->{'pp_use_billing_address'} == 1);
         $::Values->{'state'} = $state;
-  
+	}
+
   }
 
 #------------------------------------------------------------------------------------------------



More information about the interchange-cvs mailing list