[ic] etc/ship_notice error

[Curt Hauge]

Hi,

I have found a minor error in etc/ship_notice in IC4.8.5. I have
posted it to the bug list, but perhaps it has been fixed in a more
current version of IC.

>From the Admin --> Orders click the 'pending' link next to the order.
On this page, order_status.html, selecting 'Ship checked order lines,
send email to customer if appropriate', the ship_notice never reports
correctly to the customer. They get an email that reads "We have made
the last shipment of your order #XXXXXX, it is now complete!" instead
of "Your order #XXXXXX has been shipped!". On lines 9-12 of
etc/ship_notice it has one line mixed up with another, more
specifically, lines 10 and 12 should be interchanged (intentional play
on words):

[if scratch ship_now_complete]
We have made the last shipment of your order #[loop-code], it is now
complete!
[elsif scratch ship_notice_complete]
Your order #[loop-code] has been shipped!

should be:

[if scratch ship_notice_complete]
Your order #[loop-code] has been shipped!
[elsif scratch ship_now_complete]
We have made the last shipment of your order #[loop-code], it is now
complete!

It seems as though ship_now_complete is always = 1, so it would never
make it to ship_notice_complete. Now the shipped email to the customer
accurately reports 'Your order #XXXXXX has been shipped!'.

Hope this helps someone!

Curt Hauge

//////////////////////////////////////////////////////////////////
// Web Design - Interchange Hosting - Small Business Consulting //
// 1644 133rd Ln NE                         www.mnwebdesign.com //
// Ham Lake, MN 55304                  www.iwantaconsultant.com //
// Phone 612-598-5530                      info@mnwebdesign.com //
//////////////////////////////////////////////////////////////////