[ic] etc/ship_notice error

Mike Heins interchange-users@icdevgroup.org
Thu Mar 27 11:47:00 2003


Quoting Curt Hauge (curt@mnwebdesign.com):
> Hi,
> 
> I have found a minor error in etc/ship_notice in IC4.8.5. I have
> posted it to the bug list, but perhaps it has been fixed in a more
> current version of IC.
> 
> >From the Admin --> Orders click the 'pending' link next to the order.
> On this page, order_status.html, selecting 'Ship checked order lines,
> send email to customer if appropriate', the ship_notice never reports
> correctly to the customer. They get an email that reads "We have made
> the last shipment of your order #XXXXXX, it is now complete!" instead
> of "Your order #XXXXXX has been shipped!". On lines 9-12 of
> etc/ship_notice it has one line mixed up with another, more
> specifically, lines 10 and 12 should be interchanged (intentional play
> on words):
> 
> [if scratch ship_now_complete]
> We have made the last shipment of your order #[loop-code], it is now
> complete!
> [elsif scratch ship_notice_complete]
> Your order #[loop-code] has been shipped!
> 
> should be:
> 
> [if scratch ship_notice_complete]
> Your order #[loop-code] has been shipped!
> [elsif scratch ship_now_complete]
> We have made the last shipment of your order #[loop-code], it is now
> complete!
> 
> It seems as though ship_now_complete is always = 1, so it would never
> make it to ship_notice_complete. Now the shipped email to the customer
> accurately reports 'Your order #XXXXXX has been shipped!'.

Hmm. I do see the problem, but the solution you suggest doesn't
seem to work. Thanks for putting it in Bugzilla -- that means I or
someone else will have a chance to follow it up.

-- 
Mike Heins
Perusion -- Expert Interchange Consulting    http://www.perusion.com/
phone +1.513.523.7621      <mike@perusion.com>

"Laughter is inner jogging." -- Norman Cousins