[ic] Cookie Login over and over again

Bill Carr bill at worldwideimpact.com
Thu Nov 10 20:34:17 EST 2005


Hello ICers!
IC 5.2.0, Perl-5.8.7, Debian

It seems to me that Cookie Login is attempted every time a page is  
called unless the user is already logged in (and of course  
CookieLogin is not defined). I think it would be a good idea to try  
it once and if does it work stop trying for that session.

Dispatch.pm Line 1313 (sorry, one day I'll 'man diff')
Change this:
	if($Vend::Cfg->{CookieLogin} and ! $Vend::Session->{logged_in} ) {
		COOKIELOGIN: {
			my $username;
			my $password;
			last COOKIELOGIN
				if  exists  $CGI::values{mv_username}
				and defined $CGI::values{mv_username};
To this:
	if($Vend::Cfg->{CookieLogin} and ! $Vend::Session->{logged_in} and !  
$Scratch->{tried_cookie_login}) {
		COOKIELOGIN: {
			my $username;
			my $password;
			last COOKIELOGIN
				if  exists  $CGI::values{mv_username}
				and defined $CGI::values{mv_username};
			$Scratch->{tried_cookie_login} = 1;

What do you think?

I'm going to have a martini and some pop corn now.

Bill Carr
bill at worldwideimpact.com




More information about the interchange-users mailing list