[ic] Uninitialized values in Alias.pm and Encode.pm

[Stefan Hornburg (Racke)]

Jon Jensen wrote:
> On Fri, 26 Sep 2008, IC wrote:
> 
>> I am not sure if this is related to CharSet.pm but it seems highly 
>> likely, I get the following errors when running in debug mode:-
>>
>> Use of uninitialized value in exists at
>> /usr/lib/perl5/5.8.8/i686-linux/Encode/Alias.pm line 25.
> [snip]
> 
> Those are warnings, not errors, just to be clear.

It is an error that they show up though :-).

> 
>> In CharSet.pm it appears sub decode_urlencode is expecting 3 values 
>> but only
>> gets 2, if I uncomment the logDebug statements then I see CharSet.PM does
>> not get a value for $encoding, anyone know why?
> 
> Yes, I think it's because an "or" test should be an "and". Can you try 
> the attached patch and let me know if it stops the warnings for you?
> 

Yes, it should. Please commit it to 5.6 and up.

Regards
          Racke


-- 
LinuXia Systems => http://www.linuxia.de/
Expert Interchange Consulting and System Administration
ICDEVGROUP => http://www.icdevgroup.org/
Interchange Development Team