[ic] Interchange::Link changes - submitted for your approval

Jon Jensen jon at endpoint.com
Sat Aug 22 16:01:28 UTC 2009


On Fri, 21 Aug 2009, Grant wrote:

> I've made a couple changes to the Interchange::Link module which I think 
> have general applicability.  I've added a config option which removes 
> all blank lines from the HTML output and changed the "IC is not running" 
> message to be a little more user-friendly, although not as useful for 
> debugging.  I've left the debugging variables in, just commented.  The 
> patch is very simple.

The extra block and method call for every single line of output will slow 
things down a little. You could mitigate that like this:

     $r->content_type($set_content);
     $skip_blank_lines = $r->dir_config('NoBlankLines');
     while (<SOCK>) {
         push @out, $_ unless $skip_blank_lines and ! /\S/;
     }

Can you confirm that that still works?

Thanks,
Jon

-- 
Jon Jensen
End Point Corporation
http://www.endpoint.com/



More information about the interchange-users mailing list