[ic] Two patches to Page.pm related to AllowRemoteSearch

Peter peter at pajamian.dhs.org
Thu Feb 18 05:50:05 UTC 2010

On 18/02/10 17:08, Greg Sabino Mullane wrote:
> 2. In do_search, look for illegal files regardless of how $c arrives
> The second is a problem in do_search, in that AllowRemoteSearch is not 
> checked via _check_search_file if $c comes into the do_search sub as 
> a hash (as it can, at least in my testing on an older version of IC).
> I moved the check outside the "make it a hash if not" bit. Patch:
> http://github.com/turnstep/interchange/commit/e6e313e46bba784347715285bd0895a7612a2b78

My understanding is that if it comes in as a hash then it's not a remote
search and so it doesn't have to use the same strict checks as it
otherwise would.  In fact this change will break the new [search] tag
which is designed to replace remote searches in a safe manner.


More information about the interchange-users mailing list