[ic] [interchange] Revert "Add image file check mechanism to verify file type before passing to"

David Christensen david at endpoint.com
Sat May 14 15:35:43 UTC 2016

> On May 14, 2016, at 10:27 AM, Mike Heins <mikeh at endpoint.com> wrote:
>> The patch as written was broken and caused image.tag to not compile
>> when missing Image::Size (which is apparently only in
>> Bundle::InterchangeKitchenSink);
> No, it is in Bundle::Interchange and has been for a very long
> time. I could see it not being installed on some systems due to
> lack of libraries.

Fair enough; that was an assumption on my part as to why it was missing on the demo site.

>> in any case, the demo site broke
>> because it did not have this module. This was the motivator for the
>> investigation and further discussion around how (or if) to fix
>> this. (Had this not been the case, I likely would have ignored the
>> patch. :-))
>> I think the ecosystem of various parts here is too large to take
>> this approach with everything; *particularly* since it’s a
>> separate external program, I think it’s the external tool’s
>> responsibility to vet its own input. If we were using low-level
>> graphics libraries inside Perl to handle all the manipulations or
>> even the Image::Magick module directly (again, within Perl) I would
>> say our code has a responsibility to check things like return codes,
>> formats, etc. But it just seems like we’re committing to more than
>> we should at this point.
> I understand the viewpoint, and I am not insisting that we un-revert.
> I am just speaking up for the other point of view.

Sounds good; I understand that viewpoint.
David Christensen
End Point Corporation
david at endpoint.com

More information about the interchange-users mailing list