[ic] [interchange] Correct logic of DisplayErrors

David Christensen david at endpoint.com
Mon Sep 11 21:50:57 UTC 2017

> On Sep 11, 2017, at 12:27 PM, David Christensen <david at endpoint.com> wrote:
> Hi Mike,
> From HEAD^ (i.e., before my patch), we have the following in lib/Vend/Util.pm:
> 	$Vend::Errors .= $msg . "\n"
> 		if $Vend::Cfg->{DisplayErrors} || $Global::DisplayErrors;
> So this should be changed to also be &&, yes?  I’m happy to revert and fix this call site instead, since it sounds like there is an established reason and it wasn’t an oversight as I’d assumed. :-)

Upon reviewing this, I’ve decided to leave things as-is; this instance occurs within `logError()` which I believe could be called in either a global context or a catalog-level context.  I’m not convinced that turning this into an && won’t break this when called in a global context.

If you think I’m wrong about being wrong here :-), please feel free to push a correction for this instance.  I did go ahead and push a reversion to the commit which changed this logic.


David Christensen
End Point Corporation
david at endpoint.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Message signed with OpenPGP
URL: <http://www.icdevgroup.org/pipermail/interchange-users/attachments/20170911/1fe44c61/attachment.pgp>

More information about the interchange-users mailing list