<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Nov 3, 2017, at 1:48 PM, Peter <<a href="mailto:peter@pajamian.dhs.org" class="">peter@pajamian.dhs.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">On 04/11/17 04:18, David Christensen wrote:<br class=""><blockquote type="cite" class="">+<span class="Apple-tab-span" style="white-space:pre"> </span># standardize/handle old tagged REL tags<br class="">+<span class="Apple-tab-span" style="white-space:pre"> </span>if ($vers =~ /^REL_(\d+)_(\d+)_(\d+)(-(\d+)-g(\w+))/) {<br class="">+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>$vers = "$1.$2.$3";<br class="">+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>$vers .= '-devel-' . $6 if $4;<br class=""></blockquote><br class="">The "if $4" is redundant here, because the regex above won't match at<br class="">all without it. You probably want to make the $4 grouping optional by<br class="">following it with a "?" in the regex.<br class=""></div></div></blockquote><div><br class=""></div><div>Yeah, that was an earlier revision, cleaned some things up more since then.<div class=""><br class=""></div></div><blockquote type="cite" class=""><div class=""><div class=""><blockquote type="cite" class="">+<span class="Apple-tab-span" style="white-space:pre"> </span>}<br class="">+<span class="Apple-tab-span" style="white-space:pre"> </span>elsif ($vers =~ /^(\d+)\.(\d+)\.(\d+)(-(\d+)-g(\w+))/) {<br class="">+<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>$vers = "$1.$2.$3-devel-$6";<br class="">+<span class="Apple-tab-span" style="white-space:pre"> </span>}<br class=""></blockquote><br class="">In both of the above you're donking the commit counter (the $5 part).<br class="">I'd like to go on record saying that I like that part of the version<br class="">number because it gives an easily human-readable way to determine if a<br class="">particular commit is older or newer.<br class=""></div></div></blockquote></div><div class=""><br class=""></div><div class="">Okay, makes sense; the original motivation for transforming from git’s native format was MakeMaker was complaining about not being able to parse the version. I think that would have been the REL_… part though, so I’ll see if I can get that reintroduced.</div><div class=""><br class=""></div><div class="">Best,</div><div class=""><br class=""></div><div class="">David</div><div class=""><div class=""><div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">--<br class="">David Christensen<br class="">End Point Corporation<br class=""><a href="mailto:david@endpoint.com" class="">david@endpoint.com</a><br class="">785-727-1171<br class=""><br class=""><br class=""></div>
</div>
<br class=""></div></body></html>